From 61965560127b51585b60d8967a9cffd4b18e6c0a Mon Sep 17 00:00:00 2001
From: Robin Dittmar <robindittmar@gmail.com>
Date: Tue, 1 Sep 2026 15:29:31 +0200
Subject: [PATCH] fix: removed user_ids from create list payload; improved
 share button on invites

---
 src/api/__tests__/lists.spec.ts               |  2 +-
 src/components/InvitesPanel.vue               | 16 +++++++++--
 src/components/__tests__/InvitesPanel.spec.ts | 28 +++++++++++++++++++
 src/stores/__tests__/lists.spec.ts            |  3 +-
 src/stores/lists.ts                           |  4 +--
 src/types/list.ts                             |  1 -
 6 files changed, 46 insertions(+), 8 deletions(-)

diff --git a/src/api/__tests__/lists.spec.ts b/src/api/__tests__/lists.spec.ts
index 0978488..ddacd52 100644
--- a/src/api/__tests__/lists.spec.ts
+++ b/src/api/__tests__/lists.spec.ts
@@ -101,7 +101,7 @@ describe('lists API', () => {
     } as unknown as Response)
     global.fetch = fetchMock
 
-    const result = await createListApi({ name: 'Groceries', user_ids: [] })
+    const result = await createListApi({ name: 'Groceries' })
 
     expect(fetchMock).toHaveBeenCalledWith(
       `${API_BASE_URL}/lists`,
diff --git a/src/components/InvitesPanel.vue b/src/components/InvitesPanel.vue
index c899ed6..395797c 100644
--- a/src/components/InvitesPanel.vue
+++ b/src/components/InvitesPanel.vue
@@ -138,7 +138,11 @@ async function shareInvite(invite: Invite) {
 
   if (typeof navigator.share === 'function') {
     try {
-      await navigator.share({ title: 'Join dttmr', text: 'Use this link to create your account', url })
+      await navigator.share({
+        title: 'Join dttmr',
+        text: 'Use this link to create your account',
+        url,
+      })
       return
     } catch (err) {
       if (err instanceof Error && err.name === 'AbortError') {
@@ -248,7 +252,15 @@ function inviteDetail(invite: Invite): string {
             <span class="invite-detail">{{ inviteDetail(invite) }}</span>
 
             <div v-if="pendingDeleteId !== invite.id" class="invite-actions">
-              <button type="button" class="ticket-btn" @click="shareInvite(invite)">
+              <button
+                type="button"
+                class="ticket-btn"
+                :disabled="inviteStatus(invite) !== 'active'"
+                :title="
+                  inviteStatus(invite) !== 'active' ? 'Only active invites can be shared' : ''
+                "
+                @click="shareInvite(invite)"
+              >
                 {{ sharedId === invite.id ? 'Copied!' : 'Share' }}
               </button>
               <button
diff --git a/src/components/__tests__/InvitesPanel.spec.ts b/src/components/__tests__/InvitesPanel.spec.ts
index fe50ae3..4e38b6a 100644
--- a/src/components/__tests__/InvitesPanel.spec.ts
+++ b/src/components/__tests__/InvitesPanel.spec.ts
@@ -262,6 +262,34 @@ describe('InvitesPanel', () => {
     expect((deleteBtn.element as HTMLButtonElement).disabled).toBe(true)
   })
 
+  it('disables share for used and expired invites, but leaves expired invites deletable', async () => {
+    const usedInvite: Invite = {
+      id: 'invite-1',
+      code: 'USEDCODE',
+      consumed_at: '2026-01-01T00:00:00.000Z',
+    }
+    const expiredInvite: Invite = {
+      id: 'invite-2',
+      code: 'EXPCODE',
+      expires_at: '2020-01-01T00:00:00.000Z',
+    }
+    vi.spyOn(invitesApi, 'getInvitesApi').mockResolvedValueOnce(
+      paginated([usedInvite, expiredInvite]),
+    )
+
+    const wrapper = mount(InvitesPanel)
+    await wrapper.find('.invites-toggle').trigger('click')
+    await flushPromises()
+
+    const shareButtons = wrapper.findAll('.ticket-btn:not(.ticket-btn-danger)')
+    expect((shareButtons[0]!.element as HTMLButtonElement).disabled).toBe(true)
+    expect((shareButtons[1]!.element as HTMLButtonElement).disabled).toBe(true)
+
+    const deleteButtons = wrapper.findAll('.ticket-btn-danger')
+    expect((deleteButtons[0]!.element as HTMLButtonElement).disabled).toBe(true)
+    expect((deleteButtons[1]!.element as HTMLButtonElement).disabled).toBe(false)
+  })
+
   it('shows an error banner when loading invites fails', async () => {
     vi.spyOn(invitesApi, 'getInvitesApi').mockRejectedValueOnce(new Error('Network error'))
 
diff --git a/src/stores/__tests__/lists.spec.ts b/src/stores/__tests__/lists.spec.ts
index 7db67df..fd2be49 100644
--- a/src/stores/__tests__/lists.spec.ts
+++ b/src/stores/__tests__/lists.spec.ts
@@ -162,14 +162,13 @@ describe('useListsStore', () => {
     listsApiMocks.getListsApi.mockResolvedValueOnce([{ id: 'server-id-1', name: 'Groceries' }])
 
     const store = useListsStore()
-    const localList = await store.createList('Groceries', [])
+    const localList = await store.createList('Groceries')
 
     // wait for the fire-and-forget sync triggered by createList to settle
     await store.sync()
 
     expect(listsApiMocks.createListApi).toHaveBeenCalledWith({
       name: 'Groceries',
-      user_ids: [],
     })
     expect(store.lists.find((list) => list.id === localList.id)).toBeUndefined()
     const synced = store.lists.find((list) => list.id === 'server-id-1')
diff --git a/src/stores/lists.ts b/src/stores/lists.ts
index ad8d686..aebded0 100644
--- a/src/stores/lists.ts
+++ b/src/stores/lists.ts
@@ -134,7 +134,7 @@ export const useListsStore = defineStore('lists', () => {
     }, SYNC_DEBOUNCE_MS)
   }
 
-  async function createList(name: string, userIds: string[] = []): Promise<LocalList> {
+  async function createList(name: string): Promise<LocalList> {
     const now = new Date().toISOString()
     const localList: LocalList = {
       id: generateId(),
@@ -148,7 +148,7 @@ export const useListsStore = defineStore('lists', () => {
     upsertList(localList)
     await enqueue({
       type: 'createList',
-      payload: { name, user_ids: userIds },
+      payload: { name },
       localListId: localList.id,
     })
     scheduleSync()
diff --git a/src/types/list.ts b/src/types/list.ts
index 646848b..e65c2c3 100644
--- a/src/types/list.ts
+++ b/src/types/list.ts
@@ -18,7 +18,6 @@ export interface ListItem {
 
 export interface CreateListPayload {
   name: string
-  user_ids?: string[]
 }
 
 export interface CreateListItemPayload {