robin/dttmr-api
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: list service errors unification

Browse Source
This commit is contained in:
robin
2026-09-01 15:06:30 +02:00
parent 2e3e82e776
commit 4b703b077c
1 changed files with 18 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/domain/list.go
+17 -18
View File
@@ -8,11 +8,10 @@ import (
) )
var ( var (
ErrListIDEmpty = errors.New("list id must not be empty") ErrListIDMissing = errors.New("list id is required")
ErrListNameEmpty = errors.New("list name must not be empty") ErrListNameMissing = errors.New("list name is required")
ErrUserIDEmpty = errors.New("user id must not be empty") ErrListItemIDMissing = errors.New("list item id is required")
ErrListItemIDEmpty = errors.New("list item id must not be empty") ErrListItemTitleMissing = errors.New("list item title is required")
ErrListItemTitleEmpty = errors.New("list item title must not be empty")
ErrUserNotInList = errors.New("user not in list") ErrUserNotInList = errors.New("user not in list")
) )
@@ -59,7 +58,7 @@ func NewListService(r ListRepository) *ListService {
func (s *ListService) CreateList(ctx context.Context, authUserID string, name string) (*List, error) { func (s *ListService) CreateList(ctx context.Context, authUserID string, name string) (*List, error) {
if name == "" { if name == "" {
return nil, ErrListNameEmpty return nil, ErrListNameMissing
} }
list, err := s.repo.CreateList(ctx, name) list, err := s.repo.CreateList(ctx, name)
@@ -77,7 +76,7 @@ func (s *ListService) CreateList(ctx context.Context, authUserID string, name st
func (s *ListService) DeleteList(ctx context.Context, authUserID string, listID string) error { func (s *ListService) DeleteList(ctx context.Context, authUserID string, listID string) error {
if listID == "" { if listID == "" {
return ErrListIDEmpty return ErrListIDMissing
} }
if err := s.userAllowedToAccessList(ctx, authUserID, listID); err != nil { if err := s.userAllowedToAccessList(ctx, authUserID, listID); err != nil {
@@ -93,10 +92,10 @@ func (s *ListService) GetLists(ctx context.Context, authUserID string) ([]List,
func (s *ListService) AddUserToList(ctx context.Context, authUserID string, listID string, userID string) error { func (s *ListService) AddUserToList(ctx context.Context, authUserID string, listID string, userID string) error {
if listID == "" { if listID == "" {
return ErrListIDEmpty return ErrListIDMissing
} }
if userID == "" { if userID == "" {
return ErrUserIDEmpty return ErrUserIDMissing
} }
if err := s.userAllowedToAccessList(ctx, authUserID, listID); err != nil { if err := s.userAllowedToAccessList(ctx, authUserID, listID); err != nil {
@@ -108,10 +107,10 @@ func (s *ListService) AddUserToList(ctx context.Context, authUserID string, list
func (s *ListService) RemoveUserFromList(ctx context.Context, authUserID string, listID string, userID string) error { func (s *ListService) RemoveUserFromList(ctx context.Context, authUserID string, listID string, userID string) error {
if listID == "" { if listID == "" {
return ErrListIDEmpty return ErrListIDMissing
} }
if userID == "" { if userID == "" {
return ErrUserIDEmpty return ErrUserIDMissing
} }
if err := s.userAllowedToAccessList(ctx, authUserID, listID); err != nil { if err := s.userAllowedToAccessList(ctx, authUserID, listID); err != nil {
@@ -123,10 +122,10 @@ func (s *ListService) RemoveUserFromList(ctx context.Context, authUserID string,
func (s *ListService) CreateListItem(ctx context.Context, authUserID string, listID string, title string) (*ListItem, error) { func (s *ListService) CreateListItem(ctx context.Context, authUserID string, listID string, title string) (*ListItem, error) {
if listID == "" { if listID == "" {
return nil, ErrListIDEmpty return nil, ErrListIDMissing
} }
if title == "" { if title == "" {
return nil, ErrListItemTitleEmpty return nil, ErrListItemTitleMissing
} }
if err := s.userAllowedToAccessList(ctx, authUserID, listID); err != nil { if err := s.userAllowedToAccessList(ctx, authUserID, listID); err != nil {
@@ -138,7 +137,7 @@ func (s *ListService) CreateListItem(ctx context.Context, authUserID string, lis
func (s *ListService) DeleteListItem(ctx context.Context, authUserID string, listItemID string) error { func (s *ListService) DeleteListItem(ctx context.Context, authUserID string, listItemID string) error {
if listItemID == "" { if listItemID == "" {
return ErrListItemIDEmpty return ErrListItemIDMissing
} }
if err := s.userAllowedToAccessListItem(ctx, authUserID, listItemID); err != nil { if err := s.userAllowedToAccessListItem(ctx, authUserID, listItemID); err != nil {
@@ -150,10 +149,10 @@ func (s *ListService) DeleteListItem(ctx context.Context, authUserID string, lis
func (s *ListService) UpdateListItem(ctx context.Context, authUserID string, listItemID string, title string, isCompleted bool) error { func (s *ListService) UpdateListItem(ctx context.Context, authUserID string, listItemID string, title string, isCompleted bool) error {
if listItemID == "" { if listItemID == "" {
return ErrListItemIDEmpty return ErrListItemIDMissing
} }
if title == "" { if title == "" {
return ErrListItemTitleEmpty return ErrListItemTitleMissing
} }
if err := s.userAllowedToAccessListItem(ctx, authUserID, listItemID); err != nil { if err := s.userAllowedToAccessListItem(ctx, authUserID, listItemID); err != nil {
@@ -165,7 +164,7 @@ func (s *ListService) UpdateListItem(ctx context.Context, authUserID string, lis
func (s *ListService) SetListItemCompleted(ctx context.Context, authUserID string, listItemID string, isCompleted bool) error { func (s *ListService) SetListItemCompleted(ctx context.Context, authUserID string, listItemID string, isCompleted bool) error {
if listItemID == "" { if listItemID == "" {
return ErrListItemIDEmpty return ErrListItemIDMissing
} }
if err := s.userAllowedToAccessListItem(ctx, authUserID, listItemID); err != nil { if err := s.userAllowedToAccessListItem(ctx, authUserID, listItemID); err != nil {
@@ -177,7 +176,7 @@ func (s *ListService) SetListItemCompleted(ctx context.Context, authUserID strin
func (s *ListService) GetListItems(ctx context.Context, authUserID string, listID string) ([]ListItem, error) { func (s *ListService) GetListItems(ctx context.Context, authUserID string, listID string) ([]ListItem, error) {
if listID == "" { if listID == "" {
return nil, ErrListIDEmpty return nil, ErrListIDMissing
} }
if err := s.userAllowedToAccessList(ctx, authUserID, listID); err != nil { if err := s.userAllowedToAccessList(ctx, authUserID, listID); err != nil {